Re: transaction roots

(Sorry, resending because my mailer died...)

Greg Stein <gstein@lyra.org> writes:

> Can anybody see a problem with creating transactions based on the
> latest,
> and verifying that the base of each desired change matches that
> within the
> latest tree?

My complaint is that you're making mod_dav_svn do a whole bunch of
work that is *already* being done my svn_fs_merge() at commit-time.

Why reinvent the wheel? When you call svn_fs_commit_txn, it will
automatically decide if the user is out-of-date. You don't need to do
this check yourself as you build a txn against 'youngest'.

Why create a new codepath to test? There's no need to have two
different methods of building and committing transactions, depending
on which ra layer you use. That's just an ugly, internal
inconsistency.

Just build a txn based on whatever revision the client passes to your
replace_root() function. When you get a replace_dir(rev) and rev !=
the parent's rev, then call svn_fs_copy. That's what ra_local does.
Received on Sat Oct 21 14:36:26 2006