[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/client util.c Makefile.am TODO main.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-03-19 05:34:46 CET

On Mon, Mar 19, 2001 at 02:53:16AM -0000, fitz@tigris.org wrote:
> 1.1 subversion/subversion/client/util.c
> opt_state->args = apr_array_make (pool, 0, sizeof (svn_string_t *));

That 0 should be changed. There is no reason to create a zero-length array
and then follow it right up with inserting elements. That just guarantees
that the first thing you'll do is to reallocate. Put something like 5 in
there. It doesn't hurt to add a little extra space; it is better to waste
some slots, than to start with zero.


Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:26 2006

This is an archived mail posted to the Subversion Dev mailing list.