[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Can the --with-debug AC_ARG_WITH() be moved up?

From: Mo DeJong <mdejong_at_cygnus.com>
Date: 2001-03-18 01:39:44 CET

On Fri, 16 Mar 2001, Greg Stein wrote:

> On Thu, Mar 15, 2001 at 03:49:32PM -0800, Mo DeJong wrote:
> >...
> > Now for the patch that fixes the problem.
> > It is dead simple, the patch just moves
> > the AC_ARG_WITH(debug,...) up a few lines.
>
> The right answer is for APR and SVN (and Apache) to use --enable-debug and
> --enable-maintainer-mode. The WITH form is just wrong, and always has been.
> APR used it because the autoconf script was written by an autoconf newbie;
> we just copied it so that our command-line flag would be used by APR, too.

I agree that is the "right" solution, it is just that getting the
APR folks to fix "creative" uses of autoconf is like pulling
teeth. At any rate, here is a patch to fix the subversion
end of things.

2001-03-17 Mo DeJong <mdejong@redhat.com>

        * configure.in: Rename --with-debug and
        --with-maintainer-mode to --enable-debug
        and --enable-maintainer-mode.

Index: configure.in
===================================================================
RCS file: /cvs/subversion/configure.in,v
retrieving revision 1.70
diff -u -r1.70 configure.in
--- configure.in 2001/03/16 22:48:59 1.70
+++ configure.in 2001/03/18 00:38:20
@@ -161,26 +171,22 @@
 
 dnl Process some configuration options ----------
 
-AC_ARG_WITH(debug,
-[ --with-debug Turn on debugging and compile time warnings],
-[
- if test "$withval" != "no"; then
- enable_debugging=yes
- fi
-])
+AC_ARG_ENABLE(debug,
+[ --enable-debug Turn on debugging and compile time warnings],
+[],
+[enable_debugging=yes])
 
-AC_ARG_WITH(maintainer-mode,
-[ --with-maintainer-mode Turn on debugging and very strict compile-time
+AC_ARG_ENABLE(maintainer-mode,
+[ --enable-maintainer-mode Turn on debugging and very strict compile-time
                           warnings],
+[],
 [
- if test "$withval" != "no"; then
     enable_debugging=yes
     if test "$GCC" = "yes"; then
       dnl SVN_DEBUG enables specific features for developer builds
       dnl AP_DEBUG enables specific (Apache) features for developer builds
       CFLAGS="$CFLAGS -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wshadow -DSVN_DEBUG -DAP_DEBUG";
     fi
- fi
 ])
 
 if test "$enable_debugging" = "yes"; then

Mo DeJong
Red Hat Inc
Received on Sat Oct 21 14:36:26 2006

This is an archived mail posted to the Subversion Dev mailing list.