Re: fs may not be opened

Greg Stein <gstein@lyra.org> writes:
> I just hit a problem where I called svn_fs_list_transactions() without a
> prior call to svn_fs_open_berkeley(). It segfaulted within DB because we
> tried to create a transaction (in begin_trail) using fs->env which was NULL.
>
> I'm totally fine with allowing segfaults due to caller bogosity (and prefer
> it rather than litter my code with arg validation), but figured that I'd
> raise it in case somebody disagreed.

It would be nice if the library handled this a little more gracefully.
It's kind of odd that one can have an FS that doesn't actually refer
to anything yet, and we should help people out as much as we can.

The plan was to have every function in svn_fs.h call svn_fs__check_fs
(see err.h) before it does anything else. Franklin should go and add
all those calls.
Received on Sat Oct 21 14:36:25 2006