[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_ra_local ra_plugin.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-03-10 01:50:11 CET

On Thu, Mar 08, 2001 at 06:00:17PM -0000, sussman@tigris.org wrote:
> User: sussman
> Date: 01/03/08 10:00:17
>
> Modified: subversion/include svn_ra.h
> subversion/libsvn_ra_local ra_plugin.c
> Log:
> * svn_ra.h (get_commit_editor): take base_path argument, for the same
> reason that svn_fs_get_editor now does. Namely, the client already
> knows the "grandaddy" dir where it will call replace root. It's
> silly to force the editor-driver to always begin changes at the very
> top of a revision tree.

I don't understand this part. Why isn't the root just placed at BASE_PATH?

In other words, don't open the session with "/A" and then pass "B/C/D" as
BASE_PATH. Just open the session with "/A/B/C/D".

Tossing more and more parameters at the function is a sign of weakness, IMO.
A solid abstraction should not require a bazillion parameters to control its
operation. (more params == more variability == more potential for problem)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:25 2006

This is an archived mail posted to the Subversion Dev mailing list.