[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/tests/libsvn_ra_local Makefile.am ra-local-test.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-03-10 01:30:38 CET

On Fri, Mar 09, 2001 at 05:53:43PM -0000, sussman@tigris.org wrote:
>...
> --- Makefile.am 2001/02/24 00:31:42 1.24
> +++ Makefile.am 2001/03/09 17:53:41 1.25
> @@ -6,7 +6,9 @@
> SUBDIRS = libsvn_subr \
> libsvn_delta \
> libsvn_wc \
> + libsvn_ra \
> libsvn_ra_dav \
> + libsvn_ra_local \
> libsvn_client \
> @FS_BASED_DIRS@ \
> client \

euh... nope. libsvn_ra_local is in FS_BASED_DIRS when appropriate. You can't
build it all the time -- we might not have Berkeley DB, so no FS and no
libsvn_ra_local.

libsvn_ra_dav just needs Neon, which we are guaranteed to have, so it
doesn't need autoconf magic.

>...
> --- svn_ra.h 2001/03/08 18:00:16 1.41
> +++ svn_ra.h 2001/03/09 17:53:42 1.42
>...
> +svn_error_t *
> +svn_client_get_ra_library (svn_ra_plugin_t **library,
> + void *ra_baton,
> + const char *URL,
> + apr_pool_t *pool);

This is a mistake. LIBRARY should be "const", and the resulting ripple from
that. We put a const into the hash, but extract as non-const. Big no-no.

>...
> 1.1 subversion/subversion/libsvn_ra/.cvsignore
>
> Index: .cvsignore
> ===================================================================
> ChangeLog*
> Makefile.in
> Makefile
> Debug
> Release
> *.la
> *.lo
> .deps
> .libs

I didn't realize that we put change logs down here. :-)

>...
> --- ra-local-test.c 2001/03/08 23:10:26 1.4
> +++ ra-local-test.c 2001/03/09 17:53:43 1.5
> @@ -22,7 +22,9 @@
> #include "svn_delta.h"
> #include "svn_ra.h"
> #include "svn_fs.h"
> +#include "svn_client.h"

Still need that header?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:25 2006

This is an archived mail posted to the Subversion Dev mailing list.