[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/tests/libsvn_fs fs-test.c

From: Ben Collins-Sussman <sussman_at_newton.ch.collab.net>
Date: 2001-03-03 05:16:15 CET

gstein@tigris.org writes:

> this may be just a test program, but cutesy variable name wonkiness is
> simply going to cause headaches.
> stream_to_string (svn_string_t **string,
> svn_stream_t *stream,
> - apr_pool_t *puel)
> + apr_pool_t *pool)
> set_file_contents (svn_fs_root_t *root,
> const char *path,
> const char *contents,
> - apr_pool_t *p00l)
> + apr_pool_t *pool)

Sorry, Mike Pilato and I changed them to silly names because we were
trying to suppress a gcc warning: the local pool variables were
"shadowing" the global one. We were simply following the rules about
removing warnings. Hm, maybe we should just rename them *p or
something. :)
Received on Sat Oct 21 14:36:25 2006

This is an archived mail posted to the Subversion Dev mailing list.