Greg Stein <gstein@lyra.org> writes:
> Silly warning? How about silly code? Why isn't it:
>
> const char *initial_revstr = "0";
>
>
> Why use a pool and apr_psprintf() for a constant value?
Doh!
-K
> On Thu, Mar 01, 2001 at 06:16:12PM -0000, kfogel@tigris.org wrote:
> > User: kfogel
> > Date: 01/03/01 10:16:12
> >
> > Modified: subversion/libsvn_wc entries.c
> > Log:
> > (svn_wc__entries_init): Use %d, not %ld, to avoid silly warning.
> >
> > Revision Changes Path
> > 1.88 +1 -1 subversion/subversion/libsvn_wc/entries.c
> >
> > Index: entries.c
> > ===================================================================
> > RCS file: /cvs/subversion/subversion/libsvn_wc/entries.c,v
> > retrieving revision 1.87
> > retrieving revision 1.88
> > diff -u -r1.87 -r1.88
> > --- entries.c 2001/02/12 04:40:10 1.87
> > +++ entries.c 2001/03/01 18:16:12 1.88
> > @@ -47,7 +47,7 @@
> > apr_status_t apr_err;
> > apr_file_t *f = NULL;
> > svn_string_t *accum = NULL;
> > - char *initial_revstr = apr_psprintf (pool, "%ld", 0);
> > + char *initial_revstr = apr_psprintf (pool, "%d", 0);
> >
> > /* Create the entries file, which must not exist prior to this. */
> > err = svn_wc__open_adm_file (&f, path, SVN_WC__ADM_ENTRIES,
> >
> >
> >
>
> --
> Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:24 2006