Re: CVS update: subversion/subversion/libsvn_fs id.c

Greg Stein <gstein@lyra.org> writes:
> Another alternative is to stash a pool into app_private field of the DBT
> whenever you create it. Hmm... I wonder if that will be set properly for a
> key pulled out of the database.

Yes, exactly. The DBT's passed to the key comparison function aren't
necessarily DBT's you've created.

> I recognize that compare_nodes_keys() isn't leaking memory, but
> (accidentally) passing NULL to svn_fs_parse_id() from some other call point
> could introduce leakage.

Yeah. It would be possible to create an internal function which
actually does the parsing and can handle either a pool or zero, and
make the public function svn_fs_parse_id check its argument, and then
call that. nodes-table.c could call the internal function directly.
If you want to clean that up, go ahead.
Received on Sat Oct 21 14:36:23 2006