Re: CVS update: subversion/subversion/libsvn_fs dag.c dag.h

Karl Fogel <kfogel@galois.ch.collab.net> writes:
> Jim Blandy <jimb@zwingli.cygnus.com> writes:
> > This is another example of why I think log messages should include
> > filenames. If I'm just looking at the log, and I haven't gone and
> > pulled up the patch yet, I can't tell whether svn_fs__dag_close was
> > removed from dag.c, dag.h, or both.
>
> I wonder about this, actually. IMHO it's overkill for log messages to
> always link each changed symbol with the exact set of files it changed
> in -- it's asking something of log messages that they're not meant to
> do.

What's wrong with this?

    * libsvn_fs/dag.c (svn_fs__dag_open_path): Function moved to tree.c,
    made static, and renamed to `open_path'.
    * libsvn_fs/dag.h (svn_fs__dag_open_path): Remove declaration.

I don't think this requires a big philosophical discussion. You write
the log message once, you read it many times.
Received on Sat Oct 21 14:36:23 2006