[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_fs__open_dag

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-02-22 07:14:01 CET

On Thu, Feb 22, 2001 at 01:35:33PM +0900, Yoshiki Hayashi wrote:
> Jim Blandy <jimb@zwingli.cygnus.com> writes:
> > Great! I'll check it over tomorrow...
> One more patch. This fixes the same bug GregS pointed out
> to similar code.

Actually, the right choice is to use svn_fs__is_atom() :-)

What is the svn_fs__dag_dup function for? I didn't see it used anywhere. I'm
not sure if "dup" makes sense (rather than multiple references), so you may
want to omit that function until a need arises.

Also, note that most FS errors are generated by functions in err.c. This
would include a "corrupt <whatever>" rather than using abort(). The "not
found" would also go into err.c


Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:23 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.