Re: [PATCH] svn_fs__open_dag

Yoshiki Hayashi <yoshiki@xemacs.org> writes:
> I wanted to be more familiar with libsvn_fs code so I
> started writing part of it. But be careful! This is my
> first real function in subversion. You might want to
> rewrite it from scratch. It does compile and I think it's
> correct, though.

Great! I'll check it over tomorrow...

> I have one question with regard to svn_fs__dag_close which
> was just deleted. It's still referenced by tree.c and I'd
> like to resurrect it. It will call just apr_pool_destroy
> (dag->pool) if I understand it correctly. The problem of
> current implementation is that dag->pool points to
> trail->pool. Shouldn't dag->pool be subpool of trail->pool?

Your understanding is correct. We decided that it wasn't important
enough to free dag nodes before their underlying pools were freed.
What would you like to do with svn_fs__dag_close, other than free
memory?

> Oh, the downside of different timezone is that we can't
> communicate in real time basis. :-)

Unless one is annoying one's family by staying up late and reading
mail... :)
Received on Sat Oct 21 14:36:23 2006