Re: CVS update: subversion/subversion/libsvn_fs dag.c

On Wed, Feb 21, 2001 at 11:28:27PM -0000, cmpilato@tigris.org wrote:
>...
> --- dag.c 2001/02/21 23:23:57 1.26
> +++ dag.c 2001/02/21 23:28:27 1.27
>...
> + /* Create a new skel for our new node, the format of which is
> + (HEADER KIND-SPECIFIC), where HEADER is (file PROPLIST ()
> + (mutable PARENT-ID)), and KIND-SPECIFIC is an empty atom. */
> +
> + /* Step 1: create the FLAG skel. */
> + flag_skel = svn_fs__make_empty_list (trail->pool);
> + svn_fs__prepend (svn_fs__str_atom (id_str->data, trail->pool),
> + flag_skel);
> + svn_fs__prepend (svn_fs__str_atom ((char *) "mutable", trail->pool),
> + flag_skel);
> + /* Now we have a FLAG skel: (mutable PARENT-ID) */
> +
> + /* Step 2: create the HEADER skel. */
> + header_skel = svn_fs__make_empty_list (trail->pool);
> + svn_fs__prepend (flag_skel, header_skel);
> + svn_fs__prepend (svn_fs__make_empty_list (trail->pool),
> + header_skel);
> + svn_fs__prepend (svn_fs__str_atom ((char *) "file", trail->pool),
> + header_skel);
> + /* Now we have a HEADER skel: (file () FLAG) */

This skel does not correspond to the comment above. Specifically, you
originally said (file PROPLIST () FLAG), but created (file () FLAG).

So... the original comment is off, or the code is off. Take your pick :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/