Re: CVS update: subversion/subversion/libsvn_subr svn_error.c

Karl Fogel <kfogel@galois.collab.net> writes:
> > Fix non-portable use of 'va_list' argument.
> >
> > * svn_error.c (make_error_internal): Don't set the 'message' field
> > of the error object here. (svn_error_create, svn_error_createf): Set it
> > here instead.
>
> How was this non-portable? This method of passing va_list is also
> used elsewhere in the code. If it's causing a problem on some
> platforms, the above change shouldn't have made that problem go
> away...

Sorry, I didn't see your message to dev when I wrote that, Joe.

I've looked harder at the code, and I think I understand the problem
now. Passing ap is okay; but testing it (i.e., using ap itself as a
boolean value to signify whether or not ap should be used in
constructing the message) is not.

We could pass a separate boolean to make_error_internal(), to signify
whether or not ap should be used, but I can't see how that would be
better than your change.

Thanks for fixing this one,
-K
Received on Sat Oct 21 14:36:22 2006