Re: CVS update: subversion/subversion/tests/libsvn_delta xml-output-test.c

Greg Stein <gstein@lyra.org> writes:
> On Wed, Feb 14, 2001 at 09:31:07PM -0000, cmpilato@tigris.org wrote:
> >...
> > (svn_delta_edit_fns_t->add_file, add_directory): Renamed
> > ancestor_revision and ancestor_path to base_revision and base_path
> > respectively.
>
> Euh... I thought these were to be called "copyfrom_path" and
> "copyfrom_revision". That is their true/used semantic.

Yeah, Mike was saying that too in speech; probably just an oversight.
Will wait for Mike's input before changing them, though.

> General comment across the board: since we now create a "default" editor and
> then fill in functions, that default should fill in no-op functions. Thus,
> we would never need to check for NULL function values.
>
> And note that we weren't consistent with NULL-checking anyway.
>
> Anyway: we should stop checking for NULL, assume all editor functions are
> filled in, and just always call them.

Absolutely agree; will get rid of the extraneous checks.

Heh, I read over the rest of your mail, agree with all comments. Will
coordinate w/ Mike Pilato on these; no need to put them in STACK I
think, as they will be done today.

Thanks for the watchful eyes, as always, Greg.

-K
Received on Sat Oct 21 14:36:22 2006