Re: condense_targets and basepath functions
From: Greg Stein <gstein_at_lyra.org>
Date: 2001-02-08 20:17:36 CET
On Thu, Feb 08, 2001 at 11:37:48AM -0500, Kevin Pilch-Bisson wrote:
subr. I see them as part of path processing.
> 2) They currently return svn_error_t *, but nothing they call generates
Yup. Return an apr_array_header_t*, containing the svn_string_t* ptrs.
> 3) In condense_targets, I can calculate the basepath as a side-effect,
Optional return value from condense_targets. If pbasepath != NULL, then you
> 4) I have been creating a subpool of pool for temporary allocation, and
I'd say no.
SVN already spends too much time trying to be "nifty" with its allocations.
Put your allocations and temporary allocations directly into the provided
Trying to optimize memory usage now (read: prematurely) can only lead to
> 5) I could also modify the targets array and num targets directly. Thus
I'm not sure about this one. I'd initially say "no", but defer to Ben on
(1) must be fixed. Consider:
[gstein@kurgan mod_dav_svn]$ svn update . ~/src/svn/notes
(2) is no big deal. The WC has functions to detect if a given dir is a WC
(3) shouldn't be a problem. That is easily discoverable.
These last two points should be noted in the doc, so that callers can
-- Greg Stein, http://www.lyra.org/Received on Sat Oct 21 14:36:21 2006
This is an archived mail posted to the Subversion Dev mailing list.