Re: external diff headers

Branko =?ISO-8859-2?Q?=C8ibej?= <brane@xbc.nu> writes:

> > I don't understand how apr_create_pipe will solve the problem; it
> > doesn't do what popen does -- does it?
>
> It opens an anonymous pipe, same as popen. I /think/ you do an
> apr_create_pipe and use the returned handle for the output file of the
> child process (apr_setprocattr_childout).

Actually, this is neat.. BUT.

Over lunch, we decided to solve the problem of diff headers in a
better way. Better than popen().

Here's the idea:

The `svn diff' command will decide if the file in question has local
mods or not; if so, it will spawn the external diff process. (Our
local_mod_p routine already does optimizing things like examining file
mtimes and sizes.)

This will almost certainly result in a faster `svn diff'. Most of the
time we won't even have to spawn the external process now.
Received on Sat Oct 21 14:36:20 2006