[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/tests-common svn_test_editor.c

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2001-01-30 19:40:14 CET

> So get_editor() would return both an edit_baton and a
> root_dir_baton?

Yes. (In the absence of more radical changes to the editor structure
which I support but which the other developers have rejected.)

> Unless I'm missing something basic here, it is simply not the case
> that all directories with changed files are tied up until almost the
> end of the edit. A dir D is tied up just exactly as long as it
> needs to be, which is until the last postfix txdelta for a file in D
> is handled.

But postfix deltas all come at the end of the edit.

>> It's not hard, it's just more complicated and error-prone, and will
>> probably make people's lives harder in the future when it comes
>> time to debug something related to this.

> Hmm. It's hard to argue against this, as I'm sure you're aware :-).
> I'm essentially claiming the same thing, but in reverse.

Matter of opinion, I guess. I think having a couple of different
entry points to the final cleanup and extra bookkeeping in editors
which don't need to ref-count directories is likely to confuse
debuggers if that code is involved in any bugs.
Received on Sat Oct 21 14:36:20 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.