[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] added db win32 portability includes to build projects

From: Branko Čibej <brane_at_xbc.nu>
Date: 2001-01-30 01:05:40 CET

cmpilato@collab.net wrote:

> Branko =?ISO-8859-2?Q?=C8ibej?= <brane@xbc.nu> writes:
>> And it goes on to say:
>> Unpack the distribution, then set the environment variable
>> SVN_DB3_WIN32 to the full path of the db-win32 directory (use the
>> System control panel on WinNT/Win2k). MSVC will look for the include
>> files in $(SVN_DB3_WIN32)\include, and the libraries in
>> $(SVN_DB3_WIN32)\lib.
> Right. It wasn't clear in the text that you expected a user to have
> to manipulate their directory structures in order to fit snugly into
> subversion's build system (when building their own DB code from
> source). To someone unfamiliar with the problem, it reads as though
> one can simply unpack "the distribution" (with no clarification of
> that being a source or a binary one), set an environment variable, and
> off we go into blissful compilation.

I take a lot for granted, don't I. :-)

>> Oh, well. If sou think it's worth the trouble to change this and force
>> everybody to compile their own version of DB3, go ahead. Personally I'd
>> rather just put a note in HACKING that you have to copy the include
>> files and libraries into the ...\include and ...\lib directories.
> And after talking to Karl about the issue, we agree that the note in
> HACKING is indeed the easiest solution to the problem. If we get tons
> of complaints, we can spend the time to submit a patch to Berkeley
> that will create a useful directory structure, or perhaps someone else
> will do so.

O.K., I'll update HACKING to make it clearer.

But *first* I'm going to post a big complaint to the APR list for making
APR_INCOMPLETE a (non-fatal) status code from apr_stat, instead of just
setting a bit in the fileinfo.

(Yeah, GregS, your arguments in that thread were completely valid. I'm
sorry now that I didn't join in to back you up. The damn thing breaks
our client on Win32, and I'm not about to add code to handle incomplete
stats in a zillion places. $*#@&!, if you'll pardon my French.)

> That said, I accept my rejected patch like a man. :-)

See, you don't have to join the army to find a character-building
environment. :-))

Anyway, I committed you other patch, for "svn dir". I only forgot to
mention you in the log, sorry, sorry ... Karl, could you please fix that ...

Brane �ibej
    home:   <brane_at_xbc.nu>             http://www.xbc.nu/brane/
    work:   <branko.cibej_at_hermes.si>   http://www.hermes-softlab.com/
     ACM:   <brane_at_acm.org>            http://www.acm.org/
Received on Sat Oct 21 14:36:20 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.