On Thu, 25 Jan 2001, Greg Stein wrote:
> On Thu, Jan 25, 2001 at 11:26:01PM -0800, Mo DeJong wrote:
> > On Wed, 24 Jan 2001, Kevin Pilch-Bisson wrote:
> > > On Wed, Jan 24, 2001 at 02:56:38AM +0100, Branko =C8ibej wrote:
> > > > Kevin Pilch-Bisson wrote:
> > > >=20
> > > > > +dnl $MKDIR is required for configuring apr and neon in a vpath build
> > > > > +MKDIR=3Dmkdir
> > > > > +
> > > >=20
> > > > Are you sure this is right? APR uses mkdir.sh from apr/helpers. I think=
> > > =20
> > > > we should do the same.
> > > We could, I was just looking at the GNU Makefile conventions, and it
> > > said mkdir was one of the utilities we could expect all platforms to
> > > have, thus we could use it directly. However, automake generates some
> > > stuff which relies on $MKDIR, so I just set it to mkdir.
> >
> >
> > I sent a patch to the apr dev list long ago to fix this problem,
> > but it seems they never added it to the CVS. The real fix is to
> > create a MKDIR macro that does the same thing as the mkdir shell
> > script.
>
> We just expect the caller to set the MKDIR macro to a script that does the
> job. APR sets it to ./helpers/mkdir.sh. Apache sets it to
> ./srclib/apr/helpers/mkdir.sh. SVN sets it to ./apr/helpers/mkdir.sh.
>
> In this way, each "top-level" configure can tell the RUN_SUBDIR_CONFIG where
> to find the MKDIR script.
>
> It is a simpler than the MKDIR macro. However, it does place a burden on the
> user of RUN_SUBDIR_CONFIG. I've been torn on which is best, so ended up
> doing nothing :-(
(WARNING: The following is not a flame)
You call that simpler? Why give folks the chance to make an error?
The APR_MKDIR macro is hidden inside the RUN_SUBDIR_CONFIG
macro, most folks would never even know it was there. We are
already running ./configure at this point, why exec another
sh script? A macro is much faster and you would never need
to set a path to get it working.
Mo DeJong
Red Hat Inc
Received on Sat Oct 21 14:36:20 2006