[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch for supporting VPATH builds

From: Branko Čibej <brane_at_xbc.nu>
Date: 2001-01-25 00:30:20 CET

Kevin Pilch-Bisson wrote:

>> you sure this is right? APR uses mkdir.sh from apr/helpers. I think
>> we should do the same.
>
> We could, I was just looking at the GNU Makefile conventions, and it
> said mkdir was one of the utilities we could expect all platforms to
> have, thus we could use it directly. However, automake generates some
> stuff which relies on $MKDIR, so I just set it to mkdir.

APR's script creates the whole path, like "mkdir -p".

Anyway, leave it in; we can fix it if it turns out to be broken.

>> Shouldn't the header files go into EXTRA_DIST instead?
>
>
> Again, automake docs say that headers can go in source, and automake
> won't try to compile them, but will distribute them

Oh. O.K.

>> Oops. This is part of the stat patch, it has nothing to do with srcdir
>> != builddir. Don't combine different patches in one, it'll just confuse
>> people trying to review it.
>
>
> See NOTE re PATCH 1 in my second email.

Yeah, sorry. I didn't see that message until later.

-- 
Brane �ibej
    home:   <brane_at_xbc.nu>             http://www.xbc.nu/brane/
    work:   <branko.cibej_at_hermes.si>   http://www.hermes-softlab.com/
     ACM:   <brane_at_acm.org>            http://www.acm.org/
Received on Sat Oct 21 14:36:19 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.