Re: libsvn_fs/delta.c

On Fri, Jan 19, 2001 at 02:08:27PM -0600, Ben Collins-Sussman wrote:
> Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
>
> > Anyway while doing so, I took a look at libsvn_fs/delta.c and found that
> > it didn't even come close to compiling, since it used an api that seems
> > to have either never been implemented, or has been removed. I took the
> > liberty of patching up all the holes to the point where it at least
> > compiles, but I have no way or testing it. If anyone wants it, a diff
> > is included.
>
> The filesystem -- right now -- really doesn't exist yet. The library
> should always compile (as a CVS checkin rule-of-conduct), but most of
> the time this means "just comment out the non-compiling files out of
> Makefile.am".

I noticed that, I just thought it would give me something interested to
do.

>
> Starting next week, we're going to be attacking the filesystem
> full-force, but starting from the bottom up. If you look at
> libsvn_fs/structure, you'll notice that delta.c depends on *all* the
> underlying filesystem APIs below. We're still working at the bottom
> right now. The higher-level .c files have code, but a lot of may be
> old (from previous fs drafts.) If you'd like to help code at the
> bottom, talk to us some more. But for now, your attempt to make
> libsvn_fs compile isn't going to get you anywhere. You've got to
> crawl before you can walk. :)
>
Sounds good, I'll take a look some more at the structure doc. Also, I
noticed that I made one incorrect assumption in two places, (having to
do with strcmp and NULL), but I have fixed it. I won't bother sending
it since you aren't really interested, but at least I got my feet a
little bit wet with some of the subversion code. I've never used apr
before either, so I am learning a bit about the library by using it.

TTYL,

-- 
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net