Re: Subversion generic streams

> *stream = svn_stream_create(pool, rs, read_string_fn, NULL /* write */,
> NULL /* seek */);

I thought about that, of course, but it doesn't let us add stream
operations in the future, and it's less clear. (Well, it's not less
clear when you add comments like that, but you've also managed to use
about as much verbiage as I did in my two function calls.)

> It would also be simple to have utility functions:

Sure, you could have those with or without the single entry point.
But they don't save much, and there's a combinatorial variety of them
when you start thinking about bidirectional-but-not-seekable streams,
seekable-but-read-only streams, etc..

Of course, these are nits.
Received on Sat Oct 21 14:36:18 2006