[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/include svn_ra.h

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2000-12-20 18:21:16 CET

Ben Collins-Sussman <sussman@newton.collab.net> writes:
> Sorry, they're vtable routines within `svn_ra_plugin_t'. Forgot to
> indicate that. :)

Oh! If I had looked at the code, instead of just the diff, I would
have seen that myself. Sorry.

I guess you're right, though, it would be good to indicate the data
structure (svn_ra_plugin_t) that's changed by the addition of these
routines. Otherwise it's like saying "added fields foo and bar"
without mentioning which structure they were added to.

> Karl Fogel <kfogel@galois.collab.net> writes:
>
> > Are these part of a public interface, or in the global namespace? The
> > need appropriate prefixing, if so...
> >
> > -K
> >
> > sussman@tigris.org writes:
> > > Add some important parts to RA interface that we forgot, given the
> > > way that editors work. Without these things, replace_root() would be
> > > meaningless.
> > >
> > > (get_commit_editor): the client must specify a ROOT_PATH in repository
> > > that it plans to commit to. The EDIT_BATON handed back with the
> > > editor has this knowledge.
> > >
> > > (do_update): similarly, the client must supply a ROOT_PATH in the
> > > repository that represents the topmost subdir in the working copy that
> > > is being updated. The REPORT_BATON handed back should have this
> > > knowledge.
> > >
> > > Revision Changes Path
> > > 1.23 +19 -10 subversion/subversion/include/svn_ra.h
> > >
> > > Index: svn_ra.h
> > > ===================================================================
> > > RCS file: /cvs/subversion/subversion/include/svn_ra.h,v
> > > retrieving revision 1.22
> > > retrieving revision 1.23
> > > diff -u -r1.22 -r1.23
> > > --- svn_ra.h 2000/12/18 21:13:36 1.22
> > > +++ svn_ra.h 2000/12/20 19:24:10 1.23
> > > @@ -57,11 +57,12 @@
> > >
> > >
> > > /* Return an *EDITOR and *EDIT_BATON capable of transmitting a
> > > - commit to the repository. Also, ra's editor must guarantee that
> > > - if close_edit() returns successfully, that *NEW_REVISION will be
> > > - set to the repository's new revision number resulting from the
> > > - commit. */
> > > + commit to the repository beginning at absolute repository path
> > > + ROOT_PATH. Also, ra's editor must guarantee that if close_edit()
> > > + returns successfully, that *NEW_REVISION will be set to the
> > > + repository's new revision number resulting from the commit. */
> > > svn_error_t *(*get_commit_editor) (void *session_baton,
> > > + svn_string_t *root_path,
> > > const svn_delta_edit_fns_t **editor,
> > > void **edit_baton,
> > > svn_revnum_t *new_revision);
> > > @@ -78,19 +79,27 @@
> > >
> > > /* Ask the network layer to update a working copy from URL.
> > >
> > > - The network layer returns a REPORT_EDITOR and REPORT_BATON to the
> > > - client; the client then uses it to transmit an empty tree-delta
> > > - to the repository which describes all revision numbers in the
> > > - working copy.
> > > + The client library provides a ROOT_PATH (absolute path within the
> > > + repository) that represents to the topmost working copy subdir
> > > + that will be updated. The client also provides an UPDATE_EDITOR
> > > + (and baton) that can be used to modify the working copy.
> > > +
> > > + The network layer then returns a REPORT_EDITOR and REPORT_BATON
> > > + to the client; the client first uses this to transmit an empty
> > > + tree-delta to the repository which describes all revision numbers
> > > + in the working copy.
> > >
> > > There is one special property of the REPORT_EDITOR: its
> > > close_edit() function. When the client calls close_edit(), the
> > > network layer then talks to the repository and proceeds to use
> > > - UPDATE_EDITOR and UPDATE_BATON to patch the working copy!
> > > + UPDATE_EDITOR and UPDATE_BATON to patch the working copy.
> > >
> > > When the update_editor->close_edit() returns, then
> > > - report_editor->close_edit() returns too. */
> > > + report_editor->close_edit() returns too. Therefore the return
> > > + value of report_editor->close_edit() contains the result of the
> > > + entire update. */
> > > svn_error_t *(*do_update) (void *session_baton,
> > > + svn_string_t *root_path,
> > > const svn_delta_edit_fns_t **report_editor,
> > > void **report_baton,
> > > const svn_delta_edit_fns_t *update_editor,
> > >
> > >
> > >
Received on Sat Oct 21 14:36:17 2006

This is an archived mail posted to the Subversion Dev mailing list.