[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/mod_dav_svn Makefile.am

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-12-20 01:31:13 CET

On Tue, Dec 19, 2000 at 11:38:04PM +0100, Daniel Stenberg wrote:
> On Tue, 19 Dec 2000, Greg Stein wrote:
>
> > This could introduce skew between the APR used by Apache, and the APR
> > used by Subversion.
>
> Hm, why are there two different ones in the first place?

The Apache executable links against a specific APR. We need to ensure that
mod_dav_svn uses that APR.
[ hmm. same goes for fs and subr... ]

The two *should* be the same, but it will be painful the day that Apache
links against APR 1.1, and we're still on APR 1.0.

> > The APACHE_INCLUDES should point at the APR used by Apache. IOW, the
> > correct fix is to tweak APACHE_INCLUDES rather than the makefile.
>
> ... but that could itself introduce another skew if a source file includes
> apache includes and needs svn's apr include files... (no, I can't make up a
> scenario where that would happen ;-)
>
> The main problem is here is the two different APR versions in the same build.

Well, we really need to look at the executables, and which APR will be used.
The Apache executable (and mod_dav_svn/libsvn_fs/libsvn_subr) will use
whatever Apache happens to compile/link against.

Our command line and admin tools will build/link against the APR in our
directory. The obvious problem is the libsvn_subr and libsvn_fs (the latter
is linked by our server-admin tools).

If we see version skew, then we could have problems. To reduce the
possibility, we should try to compile against the correct version. For
mod_dav_svn, that is whatever Apache uses.

Yes, having two is a problem, but that will always be the case. We just need
to be careful with selecting the proper APR release. I'm guessing that we
will stop using APR's CVS and instead we'll point people at a specific APR
release distro for them to download (much like we do with Neon). APR isn't
(yet) making separate releases. If we track exactly the version that Apache
uses, then we'll never have skew. Unfortunately, that also means we track
exactly what Apache uses :-) (i.e. it makes it hard for us to use a later
version of APR to pick up some fixes or functionality)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:17 2006

This is an archived mail posted to the Subversion Dev mailing list.