[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: apr_setprocattr_childin on Win32

From: Branko Čibej <brane_at_xbc.nu>
Date: 2000-12-19 18:56:31 CET

Bill Tutt wrote:

> That wasn't all that bad.

Thanks!

I only had time to glance through your patch right now; it looks fine.
I'll take time for a good look ASAP, then see about getting it into APR.
Have to be careful about that, APR is going beta about now.

One thing you might look into is formatting the code to fit in an
80-column window. I know that particular file has longer lines, but the
rest of the code is mostly 80-column clean.

(Yes, I know how hard it is to do that in Visual Studio's editor! :-) )

> The only bummer is that apr_create_process() still
> won't work on Win9x if you want to use APR_SHELLCMD due to a bug in Win9x
> (KB: Q150956)

We don't care about that right now. A comment warning about it should be
enough. Whoever trips over it can fix it. :-)

-- 
Brane �ibej
    home:   <brane_at_xbc.nu>             http://www.xbc.nu/brane/
    work:   <branko.cibej_at_hermes.si>   http://www.hermes-softlab.com/
     ACM:   <brane_at_acm.org>            http://www.acm.org/
Received on Sat Oct 21 14:36:17 2006

This is an archived mail posted to the Subversion Dev mailing list.