[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch to support building outside the srcdir.

From: Mo DeJong <mdejong_at_cygnus.com>
Date: 2000-12-17 02:31:22 CET

On Fri, 15 Dec 2000, Greg Stein wrote:

> On Fri, Dec 15, 2000 at 10:39:57PM -0800, Mo DeJong wrote:
> > The attached patch allows one to build subversion
> > outside of the srcdir. This is really handy since
> > you can create builds for multiple CPU types or
> > with different optimizations levels from the same
> > source tree.
>
> Good stuff.
>
> >...
> > --- configure.in 2000/11/26 15:20:15 1.44
> > +++ configure.in 2000/12/16 06:28:38
> > @@ -37,8 +37,14 @@
> > enable_subdir_config=yes)
> >
> > if test "$enable_subdir_config" = "yes"; then
> > + # FIXME: This mkdir is a hack to work around a problem
> > + # with the RUN_SUBDIR_CONFIG_NOW macro. It expects the
> > + # srcdir to be the top of the apr directory. It fails
> > + # if the $1 argument is not a directory in the build dir.
> > + test -d apr || mkdir apr
> > RUN_SUBDIR_CONFIG_NOW(apr)
> > expat_absdir=`cd $srcdir/expat-lite ; pwd`
> > + test -d neon || mkdir neon
> > RUN_SUBDIR_CONFIG_NOW(neon, --with-expat=$expat_absdir/libexpat.la)
> > fi
>
> How about if we fix RUN_SUBDIR_CONFIG_NOW() rather than these workarounds?
> We certainly have access/capability to do that instead.
>
> There is some logic in RUN_SUBDIR_CONFIG_NOW to create directories and other
> crud. I'm not clear on what it is doing, but I suspect it is trying to deal
> with the above problem.
>
> In other words, can we simply fix the logic in RUN_SUBDIR_CONFIG_NOW and not
> add the above stuff?

Ok, I sent a patch to the apr list that implements this fix.
The FIXME: hack in subversion's configure.in should no longer
be needed once that patch has been accepted.

> This looks good. I think we could probably clarify some of it, if we
> introduce some config defines: APR_INCLUDES, NEON_INCLUDES, and
> EXPAT_INCLUDES. Those three would be set properly, and the makefiles would
> choose whatever they needed.
>
> Hrm. It looks like you missed updating mod_dav_svn/Makefile.am.
>
> I can do the config work for these extra *_INCLUDES macros, if the approach
> sounds right to you.

Yeah, that would be better than listing them in every Makefile.
You also might want to switch the subversion include over to
use -I$(top_srcdir)/subversion/include so that is does not need
to be subdir relative in the tests subdirs. There will
still be some relative includes in some subdirs.

Mo DeJong
Red Hat Inc
Received on Sat Oct 21 14:36:17 2006

This is an archived mail posted to the Subversion Dev mailing list.