[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: CVS update: subversion/subversion/libsvn_fs txn-table.c

From: Bill Tutt <billtut_at_microsoft.com>
Date: 2000-12-15 00:25:11 CET

On Thu, Dec 14, 2000 at 10:46:52AM -0500, Jim Blandy wrote:
> > Actually, isn't this a facet of all calls to svn_fs__*_to_dbt()?
That you're
> > feeding data to the DBT for insertion, and that nothing will attempt
> > change the DBT after that point?
> >
> > IOW, why wouldn't this cast move inside of str_to_dbt and a "const"
> > to the str_to_dbt prototype?
> BTW, I don't think it's helpful to apply to `const' to `skel_t'
> arguments. A skel is a tree, not a single node or array of nodes. So
> a `const skel_t *' argument doesn't mean "I won't modify this tree",
> which is what one really wants to say; it means "I won't modify the
> top skel of this tree, but I might munge any of the other skels it
> points to," which is useless.

Oh well, hell then. Use comments in your function definitions to
explicitly state what you mean.
Something like:

HRESULT CSwBusiness::VerifyBusinessAddress
// Check Address
// BR: If !IsOnlineBusiness, then make address fields required
// BR: If Address changed, calc new LatLong, InterleavedLatLon
        IsboContext * piSboContext,
        // [in] Needed to get datasource property
        _Recordset * piRecordset,
        // [in/out] relevant recordset
        ULONG *pulNewInterleavedLatLong,
        // [out] returns current InterleavedLatLong (for subq. bus.
        BOOL* pfDirty
        // [out] set TRUE if fields modified

Would have thought this was obvious,
Received on Sat Oct 21 14:36:17 2006

This is an archived mail posted to the Subversion Dev mailing list.