Re: CVS update: subversion/subversion/libsvn_fs txn-table.c

> Actually, isn't this a facet of all calls to svn_fs__*_to_dbt()? That you're
> feeding data to the DBT for insertion, and that nothing will attempt to
> change the DBT after that point?
>
> IOW, why wouldn't this cast move inside of str_to_dbt and a "const" applied
> to the str_to_dbt prototype?

BTW, I don't think it's helpful to apply to `const' to `skel_t'
arguments. A skel is a tree, not a single node or array of nodes. So
a `const skel_t *' argument doesn't mean "I won't modify this tree",
which is what one really wants to say; it means "I won't modify the
top skel of this tree, but I might munge any of the other skels it
points to," which is useless.
Received on Sat Oct 21 14:36:17 2006