Re: name conflicts between neon and system headers

I sent Joe a patch for this last week when I increased the strictness :-)

Joe has applied them, but we won't see them until his next release. Until
then, you can go into nsocket.h and change "socket" to "sock".

Cheers,
-g

On Mon, Dec 04, 2000 at 10:08:37AM -0600, Karl Fogel wrote:
> When I build the entire Subversion tree from clean, including the neon
> subdir, I get warnings because the param name `socket' is conflicting
> [presumably] with the socket() prototype declared in sys/socket.h.
>
> Joe, if you build with -Wall, do you get the same thing? Is this
> worth fixing? (IMHO yes; it's nice to build without warnings. Could
> just use a param named `sock' as per tradition...)
>
> Here are the warnings:
>
> make[4]: Entering directory `/home/kfogel/src/subversion/subversion/libsvn_ra_dav'
> /bin/sh ../../libtool --silent --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../include -I../../apr/include -I../../neon/src -D_REENTRANT -I/usr/local/include/db3 -pthread -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wshadow -Wredundant-decls -DSVN_DEBUG -DAP_DEBUG -g -Wall -c session.c
> In file included from session.c:21:
> ../../neon/src/nsocket.h:130: warning: declaration of `socket' shadows global declaration
> ../../neon/src/nsocket.h:141: warning: declaration of `socket' shadows global declaration
> /bin/sh ../../libtool --silent --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../include -I../../apr/include -I../../neon/src -D_REENTRANT -I/usr/local/include/db3 -pthread -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wshadow -Wredundant-decls -DSVN_DEBUG -DAP_DEBUG -g -Wall -c fetch.c
> In file included from ../../neon/src/http_request.h:29,
> from ../../neon/src/http_basic.h:29,
> from fetch.c:23:
> ../../neon/src/nsocket.h:130: warning: declaration of `socket' shadows global declaration
> ../../neon/src/nsocket.h:141: warning: declaration of `socket' shadows global declaration
> /bin/sh ../../libtool --silent --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../include -I../../apr/include -I../../neon/src -D_REENTRANT -I/usr/local/include/db3 -pthread -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wshadow -Wredundant-decls -DSVN_DEBUG -DAP_DEBUG -g -Wall -c commit.c
> In file included from ../../neon/src/http_request.h:29,
> from commit.c:17:
> ../../neon/src/nsocket.h:130: warning: declaration of `socket' shadows global declaration
> ../../neon/src/nsocket.h:141: warning: declaration of `socket' shadows global declaration
> /bin/sh ../../libtool --silent --mode=link gcc -pthread -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wshadow -Wredundant-decls -DSVN_DEBUG -DAP_DEBUG -g -Wall -o libsvn_ra_dav.la -rpath /usr/local/lib session.lo fetch.lo commit.lo -lcrypt -lnsl -lm -ldl -L/usr/local/lib
> make[4]: Leaving directory `/home/kfogel/src/subversion/subversion/libsvn_ra_dav'

-- 
Greg Stein, http://www.lyra.org/