[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_fs skel.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-12-03 21:50:49 CET

On Sun, Dec 03, 2000 at 07:29:07PM -0000, jimb@tigris.org wrote:
> User: jimb
> Date: 00/12/03 11:29:07
>
> Modified: subversion/libsvn_fs skel.c
> Log:
> Don't #include "fs.h". This makes skel.c's independence clearer.
>
> Replace uses of NEW and NEWARRAY macros (defined in fs.h) with direct
> calls to apr_palloc. Any reader of Subversion will be used to the
> pool allocation functions anyway; unless macros like that are used
> consistently throughout the system, they're just one more level to
> read through.

Thank you! thank you! thank you!

:-)

I was pondering on whether to change some of your NEW() / memset() pairs to
direct calls to apr_pcalloc(). But that would then be a bit too much, so I
considered adding NEWZ for you, but I didn't want to promote more uses of
NEW_WHATEVER... I bailed. :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:16 2006

This is an archived mail posted to the Subversion Dev mailing list.