On Sun, Dec 03, 2000 at 01:26:28AM -0800, Greg Stein wrote:
>
> Looks like Ryan is offline, so I'll go and commit the isascii fix. I'm not
> sure on the include header stuff, though, so I'm going to pass that one up.
Well, if you look at socket.c, it really does include sa_common.c, but
you're welcome to wait.
>
> > and I'll provide a Neon patch in about 30
> > seconds.
> >
> >
> > --include-deps removes the gcc dependency generation command, which
> > other compilers understandably don't like.
>
> I think we're going to need a different solution.
Your suggestion being? What ways are there to do this properly?
>
> >...
> > These fixes are all casts, since the MetroWorks compiler is quite
> > strict about this sort of thing.
>
> Needing a cast invariably means that something *else* is wrong. Adding a
> cast is a almost always band-aid which does not solve the underlying
> problem.
>
> That said: your patch points out where some problems exist, and we can solve
> those properly.
Well, I didn't want to go around changing other peoples' interfaces,
but that is better.
> > @@ -76,7 +76,7 @@
> > memcpy (inbuf + *inbuflen, p, 3 - *inbuflen);
> > p += (3 - *inbuflen);
> > encode_group (inbuf, group);
> > - svn_string_appendbytes (str, group, 4);
> > + svn_string_appendbytes (str, (const char *)group, 4);
> > *inbuflen = 0;
> > *linelen += 4;
> > if (*linelen == BASE64_LINELEN)
> > @@ -106,7 +106,7 @@
> > memset (ingroup + len, 0, 3 - len);
> > encode_group (ingroup, outgroup);
> > memset (outgroup + (len + 1), '=', 4 - (len + 1));
> > - svn_string_appendbytes (str, outgroup, 4);
> > + svn_string_appendbytes (str, (const char *)outgroup, 4);
>
> Now that is just a dumb compiler if it is complaining about those. "char *"
> can legally be passed to a "const char *" function. The other possibility is
> that it doesn't think that "char foo[]" is compatible with "char *foo" --
> again, a big problem with the compiler.
>
> [ I believe both of those issues are consider "standard C" and we shouldn't
> "have" to cast. ]
>
> Which of the two problems is the compiler talking about? const or [] ?
The problem is with the const. I couldn't find anything about the
standard either way in a quick Google search.
>
> I'm compiling the changes now and will check in soon.
When you do, I'll test it, although if those other things (like the
deps files) don't change, there's not much point.
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
GnuPG Key:
http://www.abisource.com/~sam/key
- application/pgp-signature attachment: stored
Received on Sat Oct 21 14:36:16 2006