Problem in client/main.c

I just looked at how client/main.c invokes apr_getopt_long, and saw:

          /* Since arguments may be interleaved with options, we
             handle arguments right here in the option parsing loop,
             and manually bump opt->ind so apr_getopt_long() can
             continue.

As I have said before, this approach is fundamentally incorrect. A
bare "--" is supposed to terminate the options list, once and for all
time, and if you dive back into apr_getopt_long after you see an
APR_EOF, you'll violate that constraint.

If we want to allow arguments to be interleaved with options, that
will have to be implemented in apr_getopt_long itself, by permuting
the argv array. (This is how the gnu getopt_long does it when you
don't have POSIXLY_CORRECT set in the environment.)
Received on Sat Oct 21 14:36:15 2006