Agree, will do.
Greg Stein <gstein@lyra.org> writes:
> On Sat, Nov 18, 2000 at 02:45:50AM -0000, kfogel@tigris.org wrote:
> > User: kfogel
> > Date: 00/11/17 18:45:50
> >
> > Modified: subversion/client add-cmd.c checkout-cmd.c cl.h commit-cmd.c
> > delete-cmd.c main.c propget-cmd.c proplist-cmd.c
> > props.c propset-cmd.c status-cmd.c update-cmd.c
> > Log:
> > (svn_cl__opt_state_t): doc change.
> > (svn_cl__cmd_proc_t): put pool last. All command procedures changed.
> > (main, parse_command_options): adjust for above.
> >...
> > --- cl.h 2000/11/18 02:07:40 1.22
> > +++ cl.h 2000/11/18 02:45:49 1.23
> >...
> > typedef svn_error_t *(svn_cl__cmd_proc_t) \
> > - (int argc, const char **argv, apr_pool_t*, svn_cl__opt_state_t*);
> > + (int argc, const char **argv, svn_cl__opt_state_t *, apr_pool_t *);
>
> *) It would be nice to have names for each arg in the prototype.
> *) the opt_state can probably be a const
>
>
> [ I've been on a mission re: const for a while. there are two reasons for
> adding const: 1) "static const" data can then be passed in functions that
> are declared with 'const' (if a function does /not/ have const, then you
> cannot pass const data to it); 2) the 'const' is a semantic signal that
> the function will not be changing your data. ]
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:15 2006