[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: missing parameter in apr_errno.h (patch included)

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2000-11-10 22:54:32 CET

Sorry, there are actually three places where APR_STATUS_IS_SUCCESS is
defined, for different OS's. Here is a new patch against the pristine
apr_errno.h:

2000-11-10 Karl Fogel <kfogel@collab.net>

        * apr_errno.h (APR_STATUS_IS_SUCCESS): take parameter, so
        expansion does not result in an undeclared variable.

--- include/apr_errno.h Fri Nov 10 15:43:53 2000
+++ include/apr_errno.h Fri Nov 10 15:52:28 2000
@@ -360,7 +360,7 @@
  */
 #define APR_OS2_STATUS(e) (APR_FROM_OS_ERROR(e))
 
-#define APR_STATUS_IS_SUCCESS ((s) == APR_SUCCESS \
+#define APR_STATUS_IS_SUCCESS(s) ((s) == APR_SUCCESS \
                 || (s) == APR_OS_START_SYSERR + NO_ERROR)
 
 /* APR CANONICAL ERROR TESTS */
@@ -448,7 +448,7 @@
  */
 #define apr_get_netos_error() (APR_FROM_OS_ERROR(WSAGetLastError()))
 
-#define APR_STATUS_IS_SUCCESS ((s) == APR_SUCCESS \
+#define APR_STATUS_IS_SUCCESS(s) ((s) == APR_SUCCESS \
                 || (s) == APR_OS_START_SYSERR + ERROR_SUCCESS)
 
 /* APR CANONICAL ERROR TESTS */
@@ -504,7 +504,7 @@
 #define apr_get_os_error() (errno)
 #define apr_set_os_error(e) (errno = (e))
 
-#define APR_STATUS_IS_SUCCESS ((s) == APR_SUCCESS)
+#define APR_STATUS_IS_SUCCESS(s) ((s) == APR_SUCCESS)
 
 /* APR CANONICAL ERROR TESTS */
 #define APR_STATUS_IS_EACCES(s) ((s) == APR_EACCES)
Received on Sat Oct 21 14:36:14 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.