Re: APR patch: Win32 fixes

Greg Stein wrote:

> On Sun, Nov 05, 2000 at 11:47:47PM +0100, Branko Cibej wrote:
>
>> Two nits here.
>>
>> * apr_full_read would loop infinitely if the file was smaller than
>> the buffer, because read_with_timeout wouldn't return APR_EOF.
>> * apr_read wouldn't read because rv wasn't initialised.
>>
>>
>> * apr/file_io/win32/readwrite.c (read_with_timeout):
>> Successful ReadFile with 0 bytes read indicates end-of-file.
>> (apr_read): Initialise `rv' before use.
>
>
> This looks good except that you didn't compensate for the new return value
> from read_with_timeout() on the "buffered" case in apr_read(). I tweaked
> that one and am checking it in now...

Oops ... my bad. Thanks.

-- 
Brane �ibej
    home:   <brane_at_xbc.nu>             http://www.xbc.nu/brane/
    work:   <branko.cibej_at_hermes.si>   http://www.hermes-softlab.com/
     ACM:   <brane_at_acm.org>            http://www.acm.org/