[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_subr xml.c

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2000-11-06 21:24:46 CET

brane@tigris.org writes:
> Log:
> Oh wow, I wonder how many of those are still in there ...

Not too many, I imagine, but we'll be taking a day to go through and
make sure. (I'll bet you'll have caught them all by then. :-) )

-K

> * libsvn_subr/xml.c (amalgamate): Copy the hash keys to the pool,
> too, because otherwise the keys get clobbered when we return to
> expat-lite/xmlparse.c:doContent.
>
> Revision Changes Path
> 1.30 +1 -1 subversion/subversion/libsvn_subr/xml.c
>
> Index: xml.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_subr/xml.c,v
> retrieving revision 1.29
> retrieving revision 1.30
> diff -u -r1.29 -r1.30
> --- xml.c 2000/10/21 02:40:45 1.29
> +++ xml.c 2000/11/06 03:05:34 1.30
> @@ -270,7 +270,7 @@
> if (preserve && ((apr_hash_get (ht, key, keylen)) != NULL))
> continue;
> else
> - apr_hash_set (ht, key, keylen,
> + apr_hash_set (ht, apr_pstrndup(pool, key, keylen), keylen,
> val ? svn_string_create (val, pool) : NULL);
> }
> }
>
>
>
Received on Sat Oct 21 14:36:14 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.