Re: CVS update: subversion/subversion/libsvn_delta xml_output.c

Ben Collins-Sussman <sussman@newton.collab.net> writes:
> ?? From day 1, the spec has always defined the "value" of a
> prop-delta `set' command to be the pcdata inside the tag. So this is
> how they're currently implemented inside xml_parse.c. We definitely
> need to protect this pcdata from extra newlines!

Well, base64'ing isn't sensitive to leading or trailing newlines, so
it's okay to have the cosmetic newlines there (if I understand Greg
correctly).

> Now granted, right now properties are very simplistic -- each property
> name and value are stored completely in-memory. Someday if we decide
> to make them "streamy" like text-deltas, we'll probably want to base64
> the property values as well. But that day is not yet near.

Wait a minute -- we're not base64-encoding them now? What if someone
sends a property value that includes "<" in its text? :-)
Received on Sat Oct 21 14:36:12 2006