[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_delta xml_output.c

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2000-10-21 06:14:34 CEST

Karl committed:
> (get_to_elem, apply_textdelta): use svn_xml_protect_pcdata when
> creating text-deltas and prop-deltas.

I think this change should be reverted.

prop-delta elements do not contain meaningful pcdata, just set and
delete elements.

text-delta elements contain meaningful pcdata, but at the moment
whitespace is irrelevant in there, since the data is base64-encoded.
If we ever have other types of text-deltas, we might need to protect
their pcdata, but we might not (e.g. the cosmetic newline is fine and
good for gnudiff) and we'll need to make a bunch of other changes
anyway.
Received on Sat Oct 21 14:36:12 2006

This is an archived mail posted to the Subversion Dev mailing list.