Re: CVS update: subversion/subversion/libsvn_delta xml_parse.c

Greg Stein <gstein@lyra.org> writes:

> > - err = (* (digger->editor->replace_directory))
> > + err = digger->editor->replace_directory
>
> Consider:
>
> replace_directory(args);
>
> In the above call, is replace_directory a function pointer or the function
> name itself?

True, in your example, there's no way to tell what the symbol is.
However, I have never yet encountered that situation in this project.

In the real code above, you *know* that replace_directory is a
function pointer because I'm invoking it via two structure
de-references! The commit I just made was the result of a discussion
that jimb and I had a long, long time ago... he actually argued that
the extra (* ()) made the code less intelligible. I think most of us
have been using this style ever since, and I'm just catching up older
parts of the code.
Received on Sat Oct 21 14:36:12 2006