[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_wc/tests commit-test.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-10-17 04:40:01 CEST

apr_err is probably not a "good" exit value. I'm not aware of any specific
range values for exit() codes, but the unbounded value of apr_err doesn't
feel right.

I might suggest just exiting with (1).

Cheers,
-g

On Mon, Oct 16, 2000 at 10:07:04PM -0000, sussman@tigris.org wrote:
> User: sussman
> Date: 00/10/16 15:07:04
>
> Modified: subversion/libsvn_wc/tests commit-test.c
> Log:
> Check for errors at each point, not just at the end.
>
> Revision Changes Path
> 1.7 +13 -0 subversion/subversion/libsvn_wc/tests/commit-test.c
>
> Index: commit-test.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_wc/tests/commit-test.c,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -r1.6 -r1.7
> --- commit-test.c 2000/10/16 21:57:08 1.6
> +++ commit-test.c 2000/10/16 22:07:04 1.7
> @@ -47,10 +47,23 @@
> /* Get the generic dumb editor */
> err = svn_test_get_editor (&my_editor, &my_edit_baton,
> rootdir, 59, globalpool);
> + if (err)
> + {
> + svn_handle_error (err, stderr, 0);
> + apr_destroy_pool (globalpool);
> + exit (err->apr_err);
> + }
>
> +
> /* Call the crawler */
> err = svn_wc_crawl_local_mods (rootdir, my_editor, my_edit_baton,
> globalpool);
> + if (err)
> + {
> + svn_handle_error (err, stderr, 0);
> + apr_destroy_pool (globalpool);
> + exit (err->apr_err);
> + }
>
> /* Close the edit */
> err = my_editor->close_edit (my_edit_baton);
>
>
>

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:11 2006

This is an archived mail posted to the Subversion Dev mailing list.