[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_fs dir.c

From: Jim Blandy <jimb_at_savonarola.red-bean.com>
Date: 2000-10-16 03:52:49 CEST

Greg Stein <gstein@lyra.org> writes:

> On Sun, Oct 15, 2000 at 12:19:01AM -0500, Jim Blandy wrote:
> > Greg Stein <gstein@lyra.org> writes:
> > > On Sat, Oct 14, 2000 at 04:46:58PM -0000, jimb@tigris.org wrote:
> > > > User: jimb
> > > > Date: 00/10/14 09:46:58
> > > >
> > > > Modified: subversion/libsvn_fs dir.c
> > > > Log:
> > > > libsvn_fs/dir.c (svn_fs_open_node): Be sure to close any nodes we've
> > > > opened in the process of descending the tree, even when we return an
> > > > error.
> > >
> > > Every time a node is opened, it *is* automatically registered with a pool,
> > > right? (to ensure that it gets cleaned up no matter what)
> >
> > When you close a filesystem, the whole shebang goes away ---
> > everything it ever allocated, everything. So that level is okay.
> >
> > Now, once you've got a node object, you can register it with a pool,
> > by calling svn_fs_cleanup_node. But there's no pool argument to
> > svn_fs_open_node, to automatically register it when you open it.
> >
> > Is that good enough?
>
> It certainly sounds fine!
>
> >...
> > [ nodes and the cache w.r.t. pools ]
>
> It sounds like you made a good choice there.

Okay --- that's good to hear. I have zip experience actually using
pools, so style pointers are always welcome.
Received on Sat Oct 21 14:36:11 2006

This is an archived mail posted to the Subversion Dev mailing list.