[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_client Makefile.am

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-10-15 01:10:26 CEST

I believe the correct answer is to use an absolute path. I did that for the
Neon subpackage.

However, I don't see a handy "absolute" path variable anywhere. We'd need to
manufacture one in the top-level configuration, then substitute that down
through the system. Currently, $(top_srcdir) refers to that dir. I'd
recommend setting up $(top_absdir) for this.

Seem reasonable?

Right before the sub-package config, this could be created. Then the
expat_absdir could be torched and the --with-expat line could use
top_absdir. Then an AC_SUBST() would be needed.

Cheers,
-g

On Sat, Oct 14, 2000 at 09:05:17PM -0000, ghudson@tigris.org wrote:
> User: ghudson
> Date: 00/10/14 14:05:17
>
> Modified: subversion/libsvn_wc Makefile.am
> subversion/libsvn_client Makefile.am
> Log:
> So, putting relative paths to .la files in *_la_LIBADD to signal shared
> library dependencies doesn't work; it just breaks our shared library build.
> I'm not sure what the right way is; "-L../libsvn_foo/.libs -lsvn_foo" seems
> to work but doesn't seem very clean to me. So I removed those definitions
> entirely; we didn't have one in libsvn_delta so it can't be too bad. This
> change gets the shared library build going again, although without
> dependency information.
>
> Revision Changes Path
> 1.21 +0 -4 subversion/subversion/libsvn_wc/Makefile.am
>
> Index: Makefile.am
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_wc/Makefile.am,v
> retrieving revision 1.20
> retrieving revision 1.21
> diff -u -r1.20 -r1.21
> --- Makefile.am 2000/09/27 20:42:15 1.20
> +++ Makefile.am 2000/10/14 21:05:17 1.21
> @@ -15,10 +15,6 @@
> entries.c \
> adm_crawler.c
>
> -## Libraries this binary depends upon:
> -libsvn_wc_la_LIBADD = ../libsvn_subr/libsvn_subr.la \
> - ../../expat-lite/libexpat.la
> -
> ## Build flags ---------
>
> ## These should be variables, no? (from autoconf?)
>
>
>
> 1.7 +0 -5 subversion/subversion/libsvn_client/Makefile.am
>
> Index: Makefile.am
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_client/Makefile.am,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -r1.6 -r1.7
> --- Makefile.am 2000/10/12 17:11:51 1.6
> +++ Makefile.am 2000/10/14 21:05:17 1.7
> @@ -12,11 +12,6 @@
> add.c delete.c \
> commit.c
>
> -## Libraries this binary depends upon:
> -libsvn_client_la_LIBADD = ../libsvn_subr/libsvn_subr.la \
> - ../libsvn_wc/libsvn_wc.la \
> - ../libsvn_delta/libsvn_delta.la
> -
> ## Build flags ---------
>
> ## These should be variables, no? (from autoconf?)
>
>
>

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:11 2006

This is an archived mail posted to the Subversion Dev mailing list.