Re: CVS update: subversion/subversion/libsvn_subr svn_string.c

> O.K., maybe you can't avoid the cast in this case -- although you
> could argue that the pointer should've been (unsigned char*) in the
> first place.

String literals are char *, and so is the data passed in via a
svn_write_fn_t.

ANSI C guarantees a fair amount about the equivalence of pointers to
signed and unsigned chars, as I recall, so what I do is legal if
perhaps a bit uglier than it would be in a perfect language.

> That's so -- foo* -> void* is implicit, void* -> foo* requires a
> cast in C++, though not in C. But we decided some time ago that we
> don't want to do this (see the archives -- I opened that discussion,
> asking about `__' in identifiers;

Well, there's a difference between something which will definitely
cause a problem in C++ and something that might cause a problem if
we're really unlucky. At any rate, I assume the project will probably
remain agnostic on the issue of casting from void* to foo*.
Received on Sat Oct 21 14:36:11 2006