[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add pool pointer to svn_string_t

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2000-10-11 00:39:10 CEST

I support this change, but it might be nice to hear the opion of one
of the original Subversion people for such a basic change.

> + /* pool from which the string was originally allocated -- used only
> + for growing the string, and is NOT destroyed when the string is
> + destroyed */

You can't destroy a Subversion string, so this comment doesn't quite
make sense. I'm not sure what alternative wording to use; perhaps
"and is NOT necessarily specific to the string".

> This also removes the feature that svn_string_append* will allocate
> the string if they are passed the NULL.

That feature doesn't make sense anyway. (A string is allocated and
then immediately forgotten about.) I think someone wasn't paying
attention when they put that in.
Received on Sat Oct 21 14:36:10 2006

This is an archived mail posted to the Subversion Dev mailing list.