Re: CVS update: subversion/subversion/libsvn_delta delta.h text_delta.c vdelta.c

Some nits:

> for (;;)
> {
> - const char *current_match = NULL;
> - const char *current_match_end = NULL;
> + const char *current_match, *key;
> apr_size_t current_match_len = 0;

Please, don't declare two vars in a single statement. You save space,
yes, at the expense of readability.

Also IMNSHO all pointers should be initialized when declared. You'll
have some redundant initializations, which the compiler will elide
when optimizing; and you'll catch bugs from uninitialized pointer
usage much sooner.

> - ++here;
> + here++;

What's the point of this change? Looks just a bit gratuitous to me ...

Another thing: I notice you mixed cosmetic (formatting, typos) changes
and "real" changes in the same commit. I advise against it. It makes it
harder for other people to understand the changes.

Sorry for nagging when I'm not doing the work ... :-)

-- 
Brane �ibej
  home:   <brane_at_xbc.nu>            http://www.xbc.nu/brane/
   ACM:   <brane_at_acm.org>           http://www.acm.org/