[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [gstein@locus.apache.org: cvs commit: apache-2.0/src/lib/apr/file_io/win32 open.c]

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2000-10-07 01:12:54 CEST

Greg Stein <gstein@lyra.org> writes:
> Done. Go grab a new APR for the apr_open() change and the UUID work (since
> it sounds like Karl is going to use the latter tonite)

Can I kiss you, Greg? Or is that not in the charter for this list?

> ----- Forwarded message from gstein@locus.apache.org -----
>
> Reply-To: new-httpd@apache.org
> Date: 6 Oct 2000 22:50:54 -0000
> From: gstein@locus.apache.org
> To: apache-2.0-cvs@apache.org
> Subject: cvs commit: apache-2.0/src/lib/apr/file_io/win32 open.c
>
> gstein 00/10/06 15:50:54
>
> Modified: src/lib/apr/file_io/unix open.c
> src/lib/apr/file_io/win32 open.c
> Log:
> apr_open() always allocates storage for the apr_file_t now. The caller is no
> longer responsible for initializing their apr_file_t* to NULL.
>
> Revision Changes Path
> 1.65 +1 -4 apache-2.0/src/lib/apr/file_io/unix/open.c
>
> Index: open.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/lib/apr/file_io/unix/open.c,v
> retrieving revision 1.64
> retrieving revision 1.65
> diff -u -r1.64 -r1.65
> --- open.c 2000/09/11 18:27:57 1.64
> +++ open.c 2000/10/06 22:50:53 1.65
> @@ -85,10 +85,7 @@
> apr_status_t rv;
> #endif
>
> - if ((*new) == NULL) {
> - (*new) = (apr_file_t *)apr_pcalloc(cont, sizeof(apr_file_t));
> - }
> -
> + (*new) = (apr_file_t *)apr_pcalloc(cont, sizeof(apr_file_t));
> (*new)->cntxt = cont;
> (*new)->oflags = oflags;
> (*new)->filedes = -1;
>
>
>
> 1.50 +1 -4 apache-2.0/src/lib/apr/file_io/win32/open.c
>
> Index: open.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/lib/apr/file_io/win32/open.c,v
> retrieving revision 1.49
> retrieving revision 1.50
> diff -u -r1.49 -r1.50
> --- open.c 2000/10/06 17:24:38 1.49
> +++ open.c 2000/10/06 22:50:54 1.50
> @@ -85,10 +85,7 @@
> apr_oslevel_e level;
> apr_status_t rv;
>
> - if ((*new) == NULL) {
> - (*new) = (apr_file_t *)apr_pcalloc(cont, sizeof(apr_file_t));
> - }
> -
> + (*new) = (apr_file_t *)apr_pcalloc(cont, sizeof(apr_file_t));
> (*new)->cntxt = cont;
>
> if (flag & APR_READ) {
>
>
>
>
> ----- End forwarded message -----
>
> --
> Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:10 2006

This is an archived mail posted to the Subversion Dev mailing list.