[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_delta vcdiff_parse.c

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2000-10-03 23:01:02 CEST

Karl committed:

> + (svn_txdelta_window_t *) apr_pcalloc (parser->subpool,
> + sizeof(svn_txdelta_window_t));

So, zeroing out the bytes of a pointer and assuming it will have the
value of NULL is not correct C, although it tends to work in practice.
(It's also not clean, in my opinion, even with integral types.) So
any pointer fields of the allocated svn_txdelta_window_t should not be
assumed to be NULL. If you're aware of this and don't care, that's
okay, but I thought I'd make sure.

Apologies for failing to update the vcdiff_parse code when I changed
the window structure; I wasn't really aware of it at the time.
Received on Sat Oct 21 14:36:10 2006

This is an archived mail posted to the Subversion Dev mailing list.