Greg Hudson <ghudson@MIT.EDU> writes:
> > Actually, the only requirement right now is that apply_delta calls
> > happen while the file is open -- that is, between a file_open and
> > file_close call, so that the file's baton is active.
>
> I changed this requirement in the commit that started this thread.
> For an XML-generating consumer, the apply_delta has to come at a point
> when the consumer is ready for it--either inline, or at the end.
> There's no way the consumer can do anything intelligent if it gets an
> apply_delta while it's, say, in the middle of outputting tree deltas
> for a totally different directory.
Oh -- sorry, quite right. Making the XML generating is really
uncovering a whole lot of interesting implications, isn't it? :-)
One answer is to have the various get_foo_editor() calls document
different requirements for the editors they return. In other words,
call sequence is not a property of editors in general, but of specific
uses of editors.
For example, the XML-generating editor requires calls to be made in a
depth first fashion. The dav editor doesn't care what way you call
them. And so on. The place this would be documented is at the
function which one calls to get the editor, rather than in the
general definition of editors in svn_delta.h.
Thoughts?
Received on Sat Oct 21 14:36:09 2006