Jim Blandy <jimb@savonarola.red-bean.com> writes:
> Probably svn_txdelta_to_vcdiff needs to be flipped around. We've just
> been guessing about what the clients of these interfaces will need.
> For svn_txdelta_to_vcdiff, I was assuming we'd be transmitting the
> VCDIFF, so we've got some `select' call somewhere noticing that a
> socket is writeable, and needing more data to send across it --- thus,
> a caller-pulls interface. But looking at Apache, replies are
> generated using a caller-pushes interface. And now you want a
> caller-pushes interface too. So at this point, I think reversing
> svn_txdelta_to_vcdiff looks like a good idea.
>
> I think it should become a function that accepts an svn_write_fn_t and
> baton, and returns a svn_txdelta_window_handler_t and baton. Does
> that sound right?
M-x chiming-in-with-enthusiastic-agreement
This makes sense to me too, yah. (And I see you've already done
it, Greg, in svn_delta.h:1.104.)
(RET)
-K
Received on Sat Oct 21 14:36:09 2006